Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Materialize RangeIndex when index=True in parquet writer #7711

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

galipremsagar
Copy link
Contributor

Resolves: #6873

This PR enables support to materialize a RangeIndex when index=True. Didn't add any tests as we already test for this in test_parquet_index but we were having the tests wrong due to a typo which was writing to the same file both pandas & cudf dataframes. This test is now fixed in this PR.

@galipremsagar galipremsagar added feature request New feature or request 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Mar 24, 2021
@galipremsagar galipremsagar self-assigned this Mar 24, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner March 24, 2021 19:37
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer feature request New feature or request labels Mar 24, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #7711 (5072e6b) into branch-0.19 (7871e7a) will increase coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7711      +/-   ##
===============================================
+ Coverage        81.86%   82.50%   +0.64%     
===============================================
  Files              101      101              
  Lines            16884    17441     +557     
===============================================
+ Hits             13822    14390     +568     
+ Misses            3062     3051      -11     
Impacted Files Coverage Δ
python/cudf/cudf/core/buffer.py 84.21% <ø> (+4.96%) ⬆️
python/cudf/cudf/core/column/categorical.py 91.97% <ø> (+0.58%) ⬆️
python/cudf/cudf/core/column/column.py 87.61% <ø> (-0.15%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.63% <ø> (+0.54%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.75% <ø> (-2.12%) ⬇️
python/cudf/cudf/core/column/lists.py 90.00% <ø> (-1.40%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.83% <ø> (-0.20%) ⬇️
python/cudf/cudf/core/column/string.py 86.79% <ø> (+0.30%) ⬆️
python/cudf/cudf/core/column/timedelta.py 88.57% <ø> (+0.33%) ⬆️
python/cudf/cudf/core/column_accessor.py 96.13% <ø> (+0.82%) ⬆️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e73fff0...5072e6b. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 1417297 into rapidsai:branch-0.19 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] RangeIndex must be materialized in parquet writer when index=True in parquet writer
2 participants