Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup groupby to use host_span, device_span, device_uvector #7698

Merged
merged 5 commits into from
Mar 26, 2021

Conversation

karthikeyann
Copy link
Contributor

@karthikeyann karthikeyann commented Mar 24, 2021

addresses part of #7287

  • replaced std::vector const& with host_span<const>
  • replaced rmm::device_[u]vector const& with device_span<const>
  • replaced rmm::device_vector with rmm::device_uvector

@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 24, 2021
@karthikeyann karthikeyann requested a review from a team as a code owner March 24, 2021 11:22
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #7698 (06d27f8) into branch-0.19 (f1f1d0f) will increase coverage by 0.37%.
The diff coverage is 60.00%.

❗ Current head 06d27f8 differs from pull request most recent head 7bf0331. Consider uploading reports for the commit 7bf0331 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7698      +/-   ##
===============================================
+ Coverage        82.12%   82.49%   +0.37%     
===============================================
  Files              101      101              
  Lines            17088    17458     +370     
===============================================
+ Hits             14033    14402     +369     
- Misses            3055     3056       +1     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/lists.py 87.68% <55.55%> (-1.92%) ⬇️
python/cudf/cudf/utils/dtypes.py 89.88% <100.00%> (ø)
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/abc.py 87.23% <0.00%> (-1.14%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/struct.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f1d0f...7bf0331. Read the comment docs.

@karthikeyann
Copy link
Contributor Author

rerun tests

Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one suggestion to avoid ITM.

cpp/src/groupby/hash/groupby.cu Outdated Show resolved Hide resolved
@ttnghia
Copy link
Contributor

ttnghia commented Mar 25, 2021

Just one more comment: Please add more description for the PR.

@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b0e350b into rapidsai:branch-0.19 Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants