-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup groupby to use host_span, device_span, device_uvector #7698
Cleanup groupby to use host_span, device_span, device_uvector #7698
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7698 +/- ##
===============================================
+ Coverage 82.12% 82.49% +0.37%
===============================================
Files 101 101
Lines 17088 17458 +370
===============================================
+ Hits 14033 14402 +369
- Misses 3055 3056 +1
Continue to review full report at Codecov.
|
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one suggestion to avoid ITM.
Just one more comment: Please add more description for the PR. |
@gpucibot merge |
addresses part of #7287
std::vector const&
withhost_span<const>
rmm::device_[u]vector const&
withdevice_span<const>
rmm::device_vector
withrmm::device_uvector