-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gbenchmark for nvtext ngrams functions #7693
Add gbenchmark for nvtext ngrams functions #7693
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7693 +/- ##
===============================================
+ Coverage 81.86% 82.49% +0.62%
===============================================
Files 101 101
Lines 16884 17416 +532
===============================================
+ Hits 13822 14367 +545
+ Misses 3062 3049 -13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one question about that return std::move
@gpucibot merge |
Reference #5696
Creates a gbenchmark for
nvtext::generate_ngrams()
andnvtext::generate_character_ngrams()
functions.The benchmarks measures various string lengths and number of rows.
The
nvtext::generate_ngrams()
was refactored to use the more efficientmake_strings_children
which improved its performance by about 50%.