Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/correct cudf installed package requirements #7688

Conversation

robertmaynard
Copy link
Contributor

This rolls up all the cudf changes from #7674 that are necessary for libcudf_kafka to build against an installed version of branch-0.19.

@robertmaynard robertmaynard requested a review from a team as a code owner March 23, 2021 17:46
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Mar 23, 2021
cpp/cmake/cudf-config.cmake.in Outdated Show resolved Hide resolved
cpp/cmake/cudf-config.cmake.in Outdated Show resolved Hide resolved
@kkraus14 kkraus14 added bug Something isn't working non-breaking Non-breaking change labels Mar 23, 2021
robertmaynard and others added 4 commits March 23, 2021 15:06
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #7688 (725f0af) into branch-0.19 (5d7767e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 725f0af differs from pull request most recent head c3e43eb. Consider uploading reports for the commit c3e43eb to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7688      +/-   ##
===============================================
+ Coverage        82.08%   82.10%   +0.01%     
===============================================
  Files              101      101              
  Lines            17036    17054      +18     
===============================================
+ Hits             13984    14002      +18     
  Misses            3052     3052              
Impacted Files Coverage Δ
python/cudf/cudf/core/frame.py 89.13% <ø> (ø)
python/cudf/cudf/utils/utils.py 85.06% <ø> (-0.77%) ⬇️
python/cudf/cudf/core/column/lists.py 92.17% <100.00%> (+0.35%) ⬆️
python/cudf/cudf/core/column_accessor.py 95.87% <100.00%> (+0.58%) ⬆️
python/cudf/cudf/core/dataframe.py 90.78% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7767e...c3e43eb. Read the comment docs.

@kkraus14
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b271c06 into rapidsai:branch-0.19 Mar 24, 2021
@robertmaynard robertmaynard deleted the fix/correct_cudf_installed_package_requirements branch March 24, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants