Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gbenchmark for nvtext tokenize functions #7684

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

davidwendt
Copy link
Contributor

Reference #5696
Creates gbenchmarks for nvtext::tokenize(), nvtext::count_tokens() and nvtext::ngrams_tokenize() functions.
The benchmarks measures various string lengths and number of rows.

These functions use the make_strings_column factory optimized in #7576

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 23, 2021
@davidwendt davidwendt self-assigned this Mar 23, 2021
@davidwendt davidwendt requested a review from a team as a code owner March 23, 2021 15:20
@davidwendt davidwendt requested a review from a team as a code owner March 23, 2021 15:20
@github-actions github-actions bot added the CMake CMake build issue label Mar 23, 2021
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #7684 (8bf0c22) into branch-0.19 (7871e7a) will increase coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7684      +/-   ##
===============================================
+ Coverage        81.86%   82.47%   +0.61%     
===============================================
  Files              101      101              
  Lines            16884    17402     +518     
===============================================
+ Hits             13822    14353     +531     
+ Misses            3062     3049      -13     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/categorical.py 91.97% <ø> (+0.58%) ⬆️
python/cudf/cudf/core/column/column.py 87.86% <ø> (+0.10%) ⬆️
python/cudf/cudf/core/column/datetime.py 89.63% <ø> (+0.54%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.75% <ø> (-2.12%) ⬇️
python/cudf/cudf/core/column/lists.py 92.50% <ø> (+1.10%) ⬆️
python/cudf/cudf/core/column/numerical.py 94.83% <ø> (-0.20%) ⬇️
python/cudf/cudf/core/column/string.py 86.79% <ø> (+0.30%) ⬆️
python/cudf/cudf/core/column/timedelta.py 88.57% <ø> (+0.33%) ⬆️
python/cudf/cudf/core/column_accessor.py 95.45% <ø> (+0.14%) ⬆️
python/cudf/cudf/core/dataframe.py 90.90% <ø> (+0.44%) ⬆️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d500142...8bf0c22. Read the comment docs.

@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 24, 2021
@codereport
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6ed360c into rapidsai:branch-0.19 Mar 24, 2021
@davidwendt davidwendt deleted the benchmark-nvtext-tokenize branch March 24, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants