-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable decimal support in parquet writer #7673
Enable decimal support in parquet writer #7673
Conversation
@devavret are there any issues with round tripping decimal64 vs decimal32 in generating Arrow / Pandas compatible metadata, or is that handled by the logical / physical types in Parquet anyway? |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7673 +/- ##
===============================================
+ Coverage 81.86% 82.08% +0.22%
===============================================
Files 101 101
Lines 16884 17036 +152
===============================================
+ Hits 13822 13984 +162
+ Misses 3062 3052 -10
Continue to review full report at Codecov.
|
Correct me if I'm wrong but I thought cudf only had decimal64 cudf/python/cudf/cudf/core/dtypes.py Line 234 in 04f9021
|
For now yes, but |
Alright then yes, for that, it will be taken care of during the conversion of |
@gpucibot merge |
Resolves #7669