Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work-around for gcc7 compile error on Centos7 #7652

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Work-around for gcc7 compile error on Centos7 #7652

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed0fbb6
Work-around for gcc7 compile error on Centos7
davidwendt Mar 19, 2021
3172f04
fix style check
davidwendt Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/include/cudf/strings/detail/strings_column_factories.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,10 @@ std::unique_ptr<column> make_strings_column(IndexPairIterator begin,
auto null_mask =
(null_count > 0) ? std::move(new_nulls.first) : rmm::device_buffer{0, stream, mr};

auto const avg_bytes_per_row = bytes / std::max(strings_count - null_count, 1);
// build chars column
std::unique_ptr<column> chars_column = [&] {
// use a character-parallel kernel for long string lengths
auto const avg_bytes_per_row = bytes / std::max(strings_count - null_count, 1);
if (avg_bytes_per_row > FACTORY_BYTES_PER_ROW_THRESHOLD) {
auto const d_offsets =
device_span<size_type const>{offsets_column->view().template data<int32_t>(),
Expand Down