-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rmm::device_uvector in place of rmm::device_vector for ORC reader/writer and cudf::io::column_buffer #7614
Use rmm::device_uvector in place of rmm::device_vector for ORC reader/writer and cudf::io::column_buffer #7614
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7614 +/- ##
===============================================
+ Coverage 81.86% 82.39% +0.52%
===============================================
Files 101 101
Lines 16884 17350 +466
===============================================
+ Hits 13822 14295 +473
+ Misses 3062 3055 -7
Continue to review full report at Codecov.
|
Rerun tests |
@gpucibot merge |
Issue #7287
Replaces
device_vector
withdevice_uvector
anddevice_span
. Becausedevice_uvector
does not have a default constructor, some additional changes were required fordevice_uvector
data members.Performance impact: this change makes a measurable difference in reader benchmarks. Most string column cases are sped up around 5%, with other cases having a measurable, but less consistent improvement.