Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specifying GPU architecture in JNI build [skip ci] #7612

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Mar 16, 2021

After #7593 the variables for controlling the CUDA build for either all architectures or detected architectures changed to be based on the project name which broke the JNI build. This updates the JNI CMakeList accordingly to fix the JNI build.

@jlowe jlowe added bug Something isn't working 3 - Ready for Review Ready for review by team CMake CMake build issue Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Mar 16, 2021
@jlowe jlowe self-assigned this Mar 16, 2021
@jlowe jlowe requested a review from a team as a code owner March 16, 2021 18:48
Copy link
Contributor

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, Jason

@jlowe
Copy link
Member Author

jlowe commented Mar 16, 2021

rerun tests

@jlowe jlowe added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 16, 2021
@jlowe
Copy link
Member Author

jlowe commented Mar 16, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c1c60ba into rapidsai:branch-0.19 Mar 16, 2021
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond 5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working CMake CMake build issue Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants