Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Java host-side buffer concatenation to expose separate steps [skip ci] #7610

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Mar 16, 2021

This refactors JCudfSerialization.concatToContiguousTable to expose the separate steps of concatenating to a single host-side buffer and constructing a device-side contiguous table from that host buffer. This allows application code to perform other operations in-between those two steps.

@jlowe jlowe added 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 16, 2021
@jlowe jlowe self-assigned this Mar 16, 2021
@jlowe jlowe requested a review from a team as a code owner March 16, 2021 16:27
@jlowe
Copy link
Member Author

jlowe commented Mar 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9c6e1ba into rapidsai:branch-0.19 Mar 17, 2021
@jlowe jlowe deleted the jcudf-split-host-concat branch September 10, 2021 15:46
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants