Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gbenchmarks for string substrings functions #7603

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

davidwendt
Copy link
Contributor

Reference #5698
This creates a gbenchmark for the 4 variations of cudf::strings::slice_strings() API. The benchmarks measures various sized rows as well as strings lengths.
This PR also includes changes to substring.cu implementation cleaning up the code and using the more efficient make_strings_children. This change improved performance for all 4 functions on average by 2-3x.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 15, 2021
@davidwendt davidwendt self-assigned this Mar 15, 2021
@davidwendt davidwendt requested review from a team as code owners March 15, 2021 21:53
@github-actions github-actions bot added the CMake CMake build issue label Mar 15, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #7603 (b60ab0c) into branch-0.19 (7871e7a) will increase coverage by 0.12%.
The diff coverage is 93.22%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7603      +/-   ##
===============================================
+ Coverage        81.86%   81.99%   +0.12%     
===============================================
  Files              101      101              
  Lines            16884    16989     +105     
===============================================
+ Hits             13822    13930     +108     
+ Misses            3062     3059       -3     
Impacted Files Coverage Δ
python/cudf/cudf/core/index.py 92.86% <ø> (ø)
python/cudf/cudf/core/column/column.py 87.73% <83.33%> (-0.03%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.85% <85.71%> (-0.17%) ⬇️
python/cudf/cudf/core/frame.py 89.02% <89.47%> (+<0.01%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.75% <90.32%> (-2.12%) ⬇️
python/cudf/cudf/core/dataframe.py 90.45% <95.00%> (-0.01%) ⬇️
python/cudf/cudf/core/series.py 91.24% <95.55%> (+0.46%) ⬆️
python/cudf/cudf/core/column/string.py 86.55% <100.00%> (+0.05%) ⬆️
python/cudf/cudf/core/column_accessor.py 95.28% <100.00%> (-0.03%) ⬇️
python/cudf/cudf/core/dtypes.py 90.27% <100.00%> (+0.54%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 325d5b8...b60ab0c. Read the comment docs.

@davidwendt davidwendt changed the title Add gbenchmarks for string substrngs functions Add gbenchmarks for string substrings functions Mar 16, 2021
@davidwendt davidwendt added the Performance Performance related issue label Mar 16, 2021
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake LGTM

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4723051 into rapidsai:branch-0.19 Mar 18, 2021
@davidwendt davidwendt deleted the benchmark-strings-slice branch March 18, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Performance Performance related issue strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants