-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gbenchmarks for string substrings functions #7603
Add gbenchmarks for string substrings functions #7603
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7603 +/- ##
===============================================
+ Coverage 81.86% 81.99% +0.12%
===============================================
Files 101 101
Lines 16884 16989 +105
===============================================
+ Hits 13822 13930 +108
+ Misses 3062 3059 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMake LGTM
@gpucibot merge |
Reference #5698
This creates a gbenchmark for the 4 variations of
cudf::strings::slice_strings()
API. The benchmarks measures various sized rows as well as strings lengths.This PR also includes changes to
substring.cu
implementation cleaning up the code and using the more efficientmake_strings_children
. This change improved performance for all 4 functions on average by 2-3x.