-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor string conversion check #7599
Refactor string conversion check #7599
Conversation
You will have to change the cython/python interfaces to these too or this will not build. |
Done. |
Rerun tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cython/python refactor LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java approval
Rerun tests. |
Rerun tests. |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7599 +/- ##
===============================================
+ Coverage 81.86% 82.39% +0.52%
===============================================
Files 101 101
Lines 16884 17352 +468
===============================================
+ Hits 13822 14297 +475
+ Misses 3062 3055 -7
Continue to review full report at Codecov.
|
Rerun tests. |
Rerun tests. |
1 similar comment
Rerun tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the copyright years for these files?
Sorry I forgot that again. Just updated. |
@gpucibot merge |
This addresses #7557.
In summary:
cudf::strings::is_integer()
code fromstrings/chars_types.*
tostrings/convert/convert_integers.hpp/cu
cudf::strings::is_float()
code fromstrings/chars_types.*
tostrings/convert/convert_floats.hpp/cu
cudf::strings::all_integer()
andcudf::strings::all_float()