Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Fix Anaconda upload args #7558

Merged
merged 1 commit into from
Mar 11, 2021
Merged

FIX Fix Anaconda upload args #7558

merged 1 commit into from
Mar 11, 2021

Conversation

dillon-cullinan
Copy link
Contributor

Fixes the upload arguments introduced in this PR: #7540

Order matters!

@dillon-cullinan dillon-cullinan requested a review from a team as a code owner March 10, 2021 21:23
@github-actions github-actions bot added the gpuCI label Mar 10, 2021
@dillon-cullinan dillon-cullinan added bug Something isn't working non-breaking Non-breaking change labels Mar 10, 2021
@dillon-cullinan
Copy link
Contributor Author

@gpucibot merge

@kkraus14
Copy link
Collaborator

@gpucibot merge

@codecov
Copy link

codecov bot commented Mar 11, 2021 •
edited
Loading

Codecov Report

Merging #7558 (674a71a) into branch-0.19 (7871e7a) will increase coverage by 0.53%.
The diff coverage is 92.85%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7558      +/-   ##
===============================================
+ Coverage        81.86%   82.40%   +0.53%     
===============================================
  Files              101      101              
  Lines            16884    17342     +458     
===============================================
+ Hits             13822    14290     +468     
+ Misses            3062     3052      -10
Impacted Files Coverage Δ
python/cudf/cudf/core/index.py 93.34% <ø> (+0.48%) ⬆️
python/cudf/cudf/core/column/column.py 87.80% <75.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/numerical.py 94.85% <85.71%> (-0.17%) ⬇️
python/cudf/cudf/core/frame.py 89.12% <89.47%> (+0.10%) ⬆️
python/cudf/cudf/core/column/decimal.py 93.33% <90.47%> (-1.54%) ⬇️
python/cudf/cudf/core/dataframe.py 90.58% <95.00%> (+0.11%) ⬆️
python/cudf/cudf/core/series.py 91.57% <96.77%> (+0.78%) ⬆️
python/cudf/cudf/core/column/string.py 86.76% <100.00%> (+0.26%) ⬆️
python/cudf/cudf/core/indexing.py 96.29% <100.00%> (+0.23%) ⬆️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0155bb1...6d6b7f8. Read the comment docs.

@rapids-bot rapids-bot bot merged commit c76949e into rapidsai:branch-0.19 Mar 11, 2021
hyperbolic2346 pushed a commit to hyperbolic2346/cudf that referenced this pull request Mar 25, 2021
@dillon-cullinan @hyperbolic2346
FIX Fix Anaconda upload args (rapidsai#7558)
0d8db61 
Fixes the upload arguments introduced in this PR: rapidsai#7540

Order matters!

Authors:
  - Dillon Cullinan (@dillon-cullinan)

Approvers:
  - Keith Kraus (@kkraus14)
  - AJ Schmidt (@ajschmidt8)

URL: rapidsai#7558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dillon-cullinan @kkraus14 @ajschmidt8