Make sure rmm::rmm CMake target is visibile to cudf users #7524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CMake
kkraus14
approved these changes
Mar 6, 2021
robertmaynard
force-pushed
the
make_sure_rmm_target_is_global
branch
from
d347970
to
b8e5b55
Compare
kkraus14
added
the
5 - Ready to Merge
robertmaynard
force-pushed
the
make_sure_rmm_target_is_global
branch
from
b8e5b55
to
0ede297
Compare
|
robertmaynard
force-pushed
the
make_sure_rmm_target_is_global
branch
from
0ede297
to
2f392ca
Compare
robertmaynard
force-pushed
the
make_sure_rmm_target_is_global
branch
from
2f392ca
to
f01e50a
Compare
|
@gpucibot merge |
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
) Presume that a project is using `cudf` via CPM like the following, and the machine doesn't have cudf installed, but does have rmm. ``` CPMAddPackage(NAME cudf VERSION "0.19.0" GIT_REPOSITORY https://github.com/rapidsai/cudf.git GIT_TAG branch-0.19 GIT_SHALLOW TRUE SOURCE_SUBDIR cpp OPTIONS "BUILD_TESTS OFF" "BUILD_BENCHMARKS OFF" "ARROW_STATIC_LIB ON" "JITIFY_USE_CACHE ON" "CUDA_STATIC_RUNTIME ON" "DISABLE_DEPRECATION_WARNING ON" "AUTO_DETECT_CUDA_ARCHITECTURES ON" ) add_library(cudf_example cudf_example.cu) target_link_libraries(cudf_example PRIVATE cudf::cudf) add_library(rmm_example rmm_example.cu) target_link_libraries(rmm_example PRIVATE rmm::rmm) ``` While CPM will fail to find `cudf`, it will find the local install of `rmm` and use it. This poses a problem as CMake import targets have different default visibility compared to 'real' targets. This means that while `cudf::cudf` can see and resolve `rmm::rmm` the `rmm_example` executable won't be able to. This change makes it possible for users of cudf via CPM to directly access the `rmm::rmm` target Authors: - Robert Maynard (@robertmaynard) Approvers: - Keith Kraus (@kkraus14) URL: rapidsai#7524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presume that a project is using
cudfvia CPM like the following, and the machine doesn't have cudf installed, but does have rmm.While CPM will fail to find
cudf, it will find the local install ofrmmand use it. This poses a problem as CMake import targets have different default visibility compared to 'real' targets. This means that whilecudf::cudfcan see and resolvermm::rmmthermm_exampleexecutable won't be able to.This change makes it possible for users of cudf via CPM to directly access the
rmm::rmmtarget