Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change jit launch to safe_launch #7510

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Change jit launch to safe_launch #7510

merged 1 commit into from
Mar 4, 2021

Conversation

devavret
Copy link
Contributor

@devavret devavret commented Mar 3, 2021

Final step, closes #5133

@devavret devavret requested a review from a team as a code owner March 3, 2021 19:38
@devavret devavret requested review from jrhemstad and vuule March 3, 2021 19:38
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 3, 2021
@devavret devavret added bug Something isn't working Jitify non-breaking Non-breaking change labels Mar 3, 2021
@devavret devavret mentioned this pull request Mar 3, 2021
Closed
@ttnghia
Copy link
Contributor

ttnghia commented Mar 4, 2021

@gpucibot rerun tests.

@codecov
Copy link

codecov bot commented Mar 4, 2021 •
edited
Loading

Codecov Report

Merging #7510 (7079938) into branch-0.19 (43b44e1) will increase coverage by 0.45%.
The diff coverage is 88.02%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7510      +/-   ##
===============================================
+ Coverage        81.80%   82.26%   +0.45%     
===============================================
  Files              101      101              
  Lines            16695    17245     +550     
===============================================
+ Hits             13658    14186     +528     
- Misses            3037     3059      +22
Impacted Files Coverage Δ
python/cudf/cudf/utils/docutils.py 97.36% <50.00%> (-2.64%) ⬇️
python/cudf/cudf/testing/testing.py 80.00% <57.14%> (-1.04%) ⬇️
python/cudf/cudf/core/column/timedelta.py 88.57% <75.00%> (+0.33%) ⬆️
python/cudf/cudf/core/column/categorical.py 91.74% <77.14%> (-0.49%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.63% <78.57%> (+0.58%) ⬆️
python/dask_cudf/dask_cudf/core.py 71.67% <79.41%> (-2.60%) ⬇️
python/cudf/cudf/core/multiindex.py 82.90% <90.90%> (+0.73%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.53% <93.33%> (+0.89%) ⬆️
python/cudf/cudf/core/column_accessor.py 95.47% <95.65%> (+2.53%) ⬆️
python/cudf/cudf/core/column/column.py 87.86% <96.42%> (+0.43%) ⬆️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69b6f8...7079938. Read the comment docs.

@devavret
Copy link
Contributor Author

devavret commented Mar 4, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b20f19d into rapidsai:branch-0.19 Mar 4, 2021
@kkraus14 kkraus14 mentioned this pull request Mar 5, 2021
Closed
hyperbolic2346 pushed a commit to hyperbolic2346/cudf that referenced this pull request Mar 25, 2021
@devavret @hyperbolic2346
Change jit launch to safe_launch (rapidsai#7510)
213f1ad 
Final step, closes rapidsai#5133

Authors:
  - Devavret Makkar (@devavret)

Approvers:
  - Nghia Truong (@ttnghia)
  - Vukasin Milovanovic (@vuule)

URL: rapidsai#7510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@ttnghia ttnghia ttnghia approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad

Assignees
No one assigned
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cudf::binary_operation ignores cuda context when registering JIT compiled PTX
3 participants
@devavret @ttnghia @vuule