[REVIEW] FIX Remove random build directory generation for ccache #7508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillon-cullinan
added
non-breaking
ajschmidt8
previously approved these changes
Mar 3, 2021
mike-wendt
previously approved these changes
Mar 3, 2021
|
Failure is related to Project Flash, need to work with Ray to resolve this. I'll test ccache functionality via the PR. |
|
rerun tests |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7508 +/- ##
===============================================
+ Coverage 81.80% 82.29% +0.48%
===============================================
Files 101 101
Lines 16695 17264 +569
===============================================
+ Hits 13658 14208 +550
- Misses 3037 3056 +19
Continue to review full report at Codecov.
|
ajschmidt8
approved these changes
Mar 8, 2021
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
This changes the root directory of the build folder for conda. Instead of generating a random build folder name, it will create a consistent build folder name at the `croot` location. This folder name is unique in CI, as every build has a unique `${WORKSPACE}` that is used.
Lots of workarounds added to properly work with Project Flash. Several `mv` commands are added to put build artifacts in a folder Project Flash expects them to be in.
Authors:
- Dillon Cullinan (@dillon-cullinan)
Approvers:
- AJ Schmidt (@ajschmidt8)
URL: rapidsai#7508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the root directory of the build folder for conda. Instead of generating a random build folder name, it will create a consistent build folder name at the
crootlocation. This folder name is unique in CI, as every build has a unique${WORKSPACE}that is used.Lots of workarounds added to properly work with Project Flash. Several
mvcommands are added to put build artifacts in a folder Project Flash expects them to be in.