Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] xfail failing pytest in pandas 1.2.3 #7507

Merged
merged 3 commits into from
Mar 3, 2021

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Mar 3, 2021

Looks like a new patch to the version of 1.2 was released(1.2.3) and this breaks one of our pytest. xfailing that pytest for 1.2.3.

@galipremsagar galipremsagar self-assigned this Mar 3, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner March 3, 2021 18:51
@github-actions github-actions bot added the conda label Mar 3, 2021
@galipremsagar galipremsagar added gpuCI non-breaking Non-breaking change labels Mar 3, 2021
@galipremsagar galipremsagar added the improvement Improvement / enhancement to an existing function label Mar 3, 2021
Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trxcllnt depending how the other repos resolve, we might need to update those as well to keep compose working.

just a heads up. nothing to do here.

@galipremsagar galipremsagar changed the title [REVIEW] Temporarily pin pandas to 1.2.2 [REVIEW] Pin pandas to 1.2.3 Mar 3, 2021
@github-actions github-actions bot added Python Affects Python cuDF API. and removed gpuCI labels Mar 3, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner March 3, 2021 19:37
@github-actions github-actions bot removed the conda label Mar 3, 2021
@kkraus14 kkraus14 added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Mar 3, 2021
@kkraus14
Copy link
Collaborator

kkraus14 commented Mar 3, 2021

@gpucibot merge

@galipremsagar galipremsagar changed the title [REVIEW] Pin pandas to 1.2.3 [REVIEW] xfail failing pytest in pandas 1.2.3 Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #7507 (7e8a67e) into branch-0.19 (43b44e1) will increase coverage by 0.47%.
The diff coverage is 88.07%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7507      +/-   ##
===============================================
+ Coverage        81.80%   82.28%   +0.47%     
===============================================
  Files              101      101              
  Lines            16695    17248     +553     
===============================================
+ Hits             13658    14192     +534     
- Misses            3037     3056      +19     
Impacted Files Coverage Δ
python/cudf/cudf/utils/docutils.py 97.36% <50.00%> (-2.64%) ⬇️
python/cudf/cudf/testing/testing.py 80.00% <57.14%> (-1.04%) ⬇️
python/cudf/cudf/core/column/timedelta.py 88.57% <75.00%> (+0.33%) ⬆️
python/cudf/cudf/core/column/categorical.py 91.74% <77.14%> (-0.49%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.63% <78.57%> (+0.58%) ⬆️
python/dask_cudf/dask_cudf/core.py 71.67% <79.41%> (-2.60%) ⬇️
python/cudf/cudf/core/multiindex.py 82.90% <90.90%> (+0.73%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.53% <93.33%> (+0.89%) ⬆️
python/cudf/cudf/core/column_accessor.py 95.47% <95.65%> (+2.53%) ⬆️
python/cudf/cudf/core/column/column.py 87.86% <96.42%> (+0.43%) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69b6f8...7e8a67e. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 4d0c160 into rapidsai:branch-0.19 Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants