Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNI bit cast [skip ci] #7493

Merged
merged 13 commits into from
Mar 3, 2021
Merged

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Mar 3, 2021

In #7373 logical_cast is renamed to bit_cast. That breaks JNI, and this fixes it.

@revans2 revans2 added Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 3, 2021
@revans2 revans2 self-assigned this Mar 3, 2021
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Mar 3, 2021
@revans2 revans2 changed the title JNI bit cast JNI bit cast [skip ci] Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #7493 (def9277) into branch-0.19 (43b44e1) will increase coverage by 0.45%.
The diff coverage is 88.02%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7493      +/-   ##
===============================================
+ Coverage        81.80%   82.26%   +0.45%     
===============================================
  Files              101      101              
  Lines            16695    17244     +549     
===============================================
+ Hits             13658    14185     +527     
- Misses            3037     3059      +22     
Impacted Files Coverage Δ
python/cudf/cudf/utils/docutils.py 97.36% <50.00%> (-2.64%) ⬇️
python/cudf/cudf/testing/testing.py 80.00% <57.14%> (-1.04%) ⬇️
python/cudf/cudf/core/column/timedelta.py 88.57% <75.00%> (+0.33%) ⬆️
python/cudf/cudf/core/column/categorical.py 91.74% <77.14%> (-0.49%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.63% <78.57%> (+0.58%) ⬆️
python/dask_cudf/dask_cudf/core.py 71.67% <79.41%> (-2.60%) ⬇️
python/cudf/cudf/core/multiindex.py 82.90% <90.90%> (+0.73%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.53% <93.33%> (+0.89%) ⬆️
python/cudf/cudf/core/column_accessor.py 95.47% <95.65%> (+2.53%) ⬆️
python/cudf/cudf/core/column/column.py 87.86% <96.42%> (+0.43%) ⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd6f94...305f249. Read the comment docs.

@revans2 revans2 marked this pull request as ready for review March 3, 2021 15:21
@revans2 revans2 requested review from a team as code owners March 3, 2021 15:21
@revans2 revans2 requested a review from trxcllnt March 3, 2021 15:21
@revans2 revans2 requested a review from jrhemstad March 3, 2021 15:21
@github-actions github-actions bot removed libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Mar 3, 2021
@jlowe jlowe removed request for a team, trxcllnt and jrhemstad March 3, 2021 15:23
@revans2
Copy link
Contributor Author

revans2 commented Mar 3, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c69b6f8 into rapidsai:branch-0.19 Mar 3, 2021
@revans2 revans2 deleted the bit_cast_jni branch March 3, 2021 15:24
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants