-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JNI bit cast [skip ci] #7493
Merged
Merged
JNI bit cast [skip ci] #7493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of bit_cast: FromType and ToType must have the same size and are trivially copyable.
# Conflicts: # cpp/tests/CMakeLists.txt
revans2
added
Java
Affects Java cuDF API.
4 - Needs cuDF (Java) Reviewer
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Mar 3, 2021
github-actions
bot
added
CMake
CMake build issue
libcudf
Affects libcudf (C++/CUDA) code.
labels
Mar 3, 2021
razajafri
approved these changes
Mar 3, 2021
jlowe
approved these changes
Mar 3, 2021
abellina
approved these changes
Mar 3, 2021
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7493 +/- ##
===============================================
+ Coverage 81.80% 82.26% +0.45%
===============================================
Files 101 101
Lines 16695 17244 +549
===============================================
+ Hits 13658 14185 +527
- Misses 3037 3059 +22
Continue to review full report at Codecov.
|
github-actions
bot
removed
libcudf
Affects libcudf (C++/CUDA) code.
CMake
CMake build issue
labels
Mar 3, 2021
@gpucibot merge |
vyasr
added
4 - Needs Review
Waiting for reviewer to review or respond
and removed
4 - Needs cuDF (Java) Reviewer
labels
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4 - Needs Review
Waiting for reviewer to review or respond
improvement
Improvement / enhancement to an existing function
Java
Affects Java cuDF API.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7373 logical_cast is renamed to bit_cast. That breaks JNI, and this fixes it.