JNI: Support skipping nulls for collect aggregation [skip ci] #7457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a parameter controlling whether to skip nulls when creating a collect aggregation. Signed-off-by: Liangcai Li <[email protected]>
|
Can one of the admins verify this patch? |
|
@mythrocks Could you help review ? |
firestarman
changed the title
firestarman
changed the title
firestarman
added a commit
to firestarman/spark-rapids
that referenced
this pull request
Mar 1, 2021
Since cudf supports skipping null values by PRs rapidsai/cudf#7264, and rapidsai/cudf#7457. Signed-off-by: Firestarman <[email protected]>
mythrocks
requested changes
Mar 1, 2021
Since ullPolicy is more readable than a bare boolean. Signed-off-by: Firestarman <[email protected]>
revans2
added
improvement
revans2
reviewed
Mar 3, 2021
and depreacted the APIs using booleans to have the APIs been consistent. Signed-off-by: Firestarman <[email protected]>
revans2
approved these changes
Mar 4, 2021
|
@firestarman, thank you for making |
mythrocks
approved these changes
Mar 4, 2021
|
@gpucibot merge |
|
rerun tests |
|
run tests |
|
@gpucibot merge |
|
rerun tests |
mythrocks
changed the title
|
@gpucibot merge |
|
rerun tests |
|
ok to test |
|
rerun tests |
1 similar comment
|
rerun tests |
kkraus14
changed the title
|
ok to test |
firestarman
added a commit
to firestarman/spark-rapids
that referenced
this pull request
Mar 8, 2021
Since cudf supports skipping null values by PRs rapidsai/cudf#7264, and rapidsai/cudf#7457. Signed-off-by: Firestarman <[email protected]>
firestarman
added a commit
to NVIDIA/spark-rapids
that referenced
this pull request
Mar 9, 2021
Since cudf supports skipping null values by PRs rapidsai/cudf#7264, and rapidsai/cudf#7457. Signed-off-by: Firestarman <[email protected]>
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
This PR is to support skipping nulls for `collect ` aggregation in JVM by creating a new class `CollectAggregation` who accepts a `NullPolicy ` argument indicating whether to include nulls. Skipping nulls has already been supported by `collect ` aggregation with rolling in native (rapidsai#7264), so this PR just exposes the feaure in JVM. This PR also introduces `NullPolicy ` and updates the related aggregates. Signed-off-by: firestarman <[email protected]> Authors: - Liangcai Li (@firestarman) Approvers: - Robert (Bobby) Evans (@revans2) - MithunR (@mythrocks) URL: rapidsai#7457
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Since cudf supports skipping null values by PRs rapidsai/cudf#7264, and rapidsai/cudf#7457. Signed-off-by: Firestarman <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Since cudf supports skipping null values by PRs rapidsai/cudf#7264, and rapidsai/cudf#7457. Signed-off-by: Firestarman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support skipping nulls for
collectaggregation in JVM by creating a new classCollectAggregationwho accepts aNullPolicyargument indicating whether to include nulls.Skipping nulls has already been supported by
collectaggregation with rolling in native (#7264), so this PR just exposes the feaure in JVM.This PR also introduces
NullPolicyand updates the related aggregates.Signed-off-by: firestarman [email protected]