Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Series.__setitem__ with key to a new row #7443

Merged
merged 4 commits into from
Mar 10, 2021
Merged

Support Series.__setitem__ with key to a new row #7443

merged 4 commits into from
Mar 10, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Feb 24, 2021 •
edited
Loading

Closes #7290

Supports assigning to a new row (specified by a new label) in a series.

@isVoid isVoid requested a review from a team as a code owner February 24, 2021 21:39
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 24, 2021
@isVoid isVoid added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change bug Something isn't working labels Feb 25, 2021
brandon-b-miller
brandon-b-miller requested changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about testing otherwise LGTM

@isVoid isVoid self-assigned this Feb 27, 2021
@isVoid
Copy link
Contributor Author

isVoid commented Mar 3, 2021

rerun tests

@codecov
Copy link

codecov bot commented Mar 3, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@b887e58). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7443   +/-   ##
==============================================
  Coverage               ?   84.28%           
==============================================
  Files                  ?      101           
  Lines                  ?    21037           
  Branches               ?        0           
==============================================
  Hits                   ?    17730           
  Misses                 ?     3307           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b887e58...1870ce9. Read the comment docs.

galipremsagar
galipremsagar approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 4, 2021
@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar
Copy link
Contributor

@gpucibot merge

@galipremsagar
Copy link
Contributor

rerun tests

@rapids-bot rapids-bot bot merged commit 85edbfa into rapidsai:branch-0.19 Mar 10, 2021
hyperbolic2346 pushed a commit to hyperbolic2346/cudf that referenced this pull request Mar 25, 2021
@isVoid @hyperbolic2346
Support Series.__setitem__ with key to a new row (rapidsai#7443)
0e2736a 
Closes rapidsai#7290 

Supports assigning to a new row (specified by a new label) in a series.

Authors:
  - Michael Wang (@isVoid)

Approvers:
  - @brandon-b-miller
  - GALI PREM SAGAR (@galipremsagar)

URL: rapidsai#7443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

Assignees

@isVoid isVoid

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Series.__setitem__ to a new index label raises exception
3 participants
@isVoid @galipremsagar @brandon-b-miller