-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gbenchmarks for strings filter functions #7438
Add gbenchmarks for strings filter functions #7438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake lgtm
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7438 +/- ##
===============================================
+ Coverage 81.80% 81.84% +0.03%
===============================================
Files 101 101
Lines 16695 16707 +12
===============================================
+ Hits 13658 13674 +16
+ Misses 3037 3033 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, other than a couple small things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@gpucibot merge |
Reference #5698
This creates a gbenchmark for the
cudf::strings::filter_characters
,cudf::strings::filter_characters_of_type
, andcudf::strings::strip
functions.This PR also includes changes to
strip.cu
andfilter_chars
to use the more efficientmake_strings_children
utility. This improved performance on these functions by 2x on average.