Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace thrust::max_element with thrust::reduce in strings findall_re #7428

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

davidwendt
Copy link
Contributor

This is a cleanup of findall.cu to change from using thrust::max_element to the more efficient thrust::reduce with a thrust::maximum operator. This also changes device_vector usage to device_uvector and adds more const to variable decls.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team code quality improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 23, 2021
@davidwendt davidwendt self-assigned this Feb 23, 2021
@davidwendt davidwendt requested a review from a team as a code owner February 23, 2021 18:10
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Feb 23, 2021
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #7428 (0c91d44) into branch-0.19 (43b44e1) will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7428      +/-   ##
===============================================
+ Coverage        81.80%   82.23%   +0.42%     
===============================================
  Files              101      101              
  Lines            16695    17060     +365     
===============================================
+ Hits             13658    14029     +371     
+ Misses            3037     3031       -6     
Impacted Files Coverage Δ
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/struct.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/join/join.py 95.93% <0.00%> (+0.02%) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 640277e...eccc682. Read the comment docs.

Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Feb 25, 2021
@codereport
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 49f6857 into rapidsai:branch-0.19 Feb 25, 2021
@davidwendt davidwendt deleted the cleanup-findall branch February 25, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants