-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gbenchmark for strings split/split_record functions #7427
Add gbenchmark for strings split/split_record functions #7427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake lgtm
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7427 +/- ##
===============================================
+ Coverage 81.80% 82.24% +0.43%
===============================================
Files 101 101
Lines 16695 17069 +374
===============================================
+ Hits 13658 14039 +381
+ Misses 3037 3030 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for device_uvector
@gpucibot merge |
Reference #5698
This creates a gbenchmark for the
cudf::strings::split
andcudf::strings::split_record
functions.This PR also includes changes to
split.cu
to usedevice_uvector
for temporary buffers instead ofdevice_vector
and other minor code cleanup like adding moreconst
decls.