Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move nullable index iterator to indexalator factory #7399

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Move nullable index iterator to indexalator factory #7399

merged 1 commit into from
Feb 19, 2021

Conversation

davidwendt
Copy link
Contributor

Closes #6469

The cudf::dictionary::replace function uses a pair iterator over the child column indices. The logic uses an indexalator input iterator to build the pair iterator. This PR moves the pair iterator creation to the indexalator_factory so it can be used more generally.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 17, 2021
@davidwendt davidwendt self-assigned this Feb 17, 2021
@davidwendt davidwendt requested a review from a team as a code owner February 17, 2021 14:40
codereport
codereport approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@b090d96). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7399   +/-   ##
==============================================
  Coverage               ?   82.19%           
==============================================
  Files                  ?      100           
  Lines                  ?    16968           
  Branches               ?        0           
==============================================
  Hits                   ?    13947           
  Misses                 ?     3021           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b090d96...e0a5ae4. Read the comment docs.

@karthikeyann karthikeyann added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Feb 19, 2021
@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2ae7498 into rapidsai:branch-0.19 Feb 19, 2021
@davidwendt davidwendt deleted the dictionary-replace-iterator branch February 19, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codereport codereport codereport approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

Assignees

@davidwendt davidwendt

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Move nullable index iterator creation logic to indexalator_factory
3 participants
@davidwendt @karthikeyann @codereport