Refactor libcudf strings::replace to use make_strings_children utility #7384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #7370
This PR simplifies the current
cudf::strings::replace
(non-regex) functions by refactoring to use the more efficientmake_strings_children
utility. This refactoring improves performance by about 2x on these APIs as measured by the gbenchmark PR #7369.Baseline gbenchmark for replace-scalar
gbenchmark results for refactored replace-scalar
Improvements for #7370 should base off of these changes.