Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cudf::explode_position #7376

Merged
merged 9 commits into from
Feb 26, 2021

Conversation

hyperbolic2346
Copy link
Contributor

This PR adds support for pos_explode in cuDF. It is very similar to explode, but includes a column with the index of the array that was exploded on each row.

a                b
[0, 1]          100
[2]             200
[3, 4, 5]       300

exploded on column a would result in

a         pos        b
0         0         100
1         1         100
2         0         200
3         0         300
4         1         300
5         2         300

partially fixes #6151

@hyperbolic2346 hyperbolic2346 requested a review from a team as a code owner February 12, 2021 03:23
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Feb 12, 2021
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@ebe307e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7376   +/-   ##
==============================================
  Coverage               ?   82.26%           
==============================================
  Files                  ?      101           
  Lines                  ?    17075           
  Branches               ?        0           
==============================================
  Hits                   ?    14047           
  Misses                 ?     3028           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe307e...23e099a. Read the comment docs.

cpp/src/reshape/explode.cu Outdated Show resolved Hide resolved
cpp/src/reshape/explode.cu Outdated Show resolved Hide resolved
cpp/src/reshape/explode.cu Outdated Show resolved Hide resolved
cpp/src/reshape/explode.cu Outdated Show resolved Hide resolved
cpp/src/reshape/explode.cu Outdated Show resolved Hide resolved
cpp/src/reshape/explode.cu Outdated Show resolved Hide resolved
cpp/src/reshape/explode.cu Outdated Show resolved Hide resolved
cpp/src/reshape/explode.cu Outdated Show resolved Hide resolved
cpp/src/reshape/explode.cu Outdated Show resolved Hide resolved
cpp/src/reshape/explode.cu Outdated Show resolved Hide resolved
cpp/include/cudf/reshape.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/reshape.hpp Outdated Show resolved Hide resolved
@hyperbolic2346 hyperbolic2346 changed the title Adding support for pos_explode in cuDF Adding support for explode_position in cuDF Feb 17, 2021
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Check the copyright year includes 2021 in any the files you changed here.

cpp/include/cudf/lists/lists_column_view.hpp Outdated Show resolved Hide resolved
@jrhemstad jrhemstad added non-breaking Non-breaking change feature request New feature or request labels Feb 21, 2021
@harrism harrism changed the title Adding support for explode_position in cuDF Add cudf::explode_position Feb 23, 2021
@hyperbolic2346 hyperbolic2346 added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Feb 26, 2021
@hyperbolic2346
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9ae85ae into rapidsai:branch-0.19 Feb 26, 2021
@hyperbolic2346 hyperbolic2346 deleted the mwilson/pos_explode branch February 26, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] memory efficient explode and pos_explode implementations
3 participants