Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add groupby SUM_OF_SQUARES support #7362

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Add groupby SUM_OF_SQUARES support #7362

merged 3 commits into from
Feb 12, 2021

Conversation

karthikeyann
Copy link
Contributor

closes #4667

  • Add hash groupby SUM_OF_SQUARES support
  • considering ptxas 10.2 crash, it's enabled for floating types only in unit tests.

@karthikeyann karthikeyann requested review from a team as code owners February 10, 2021 06:15
@karthikeyann karthikeyann changed the base branch from branch-0.18 to branch-0.19 February 10, 2021 06:15
@github-actions github-actions bot added CMake CMake build issue conda Java Affects Java cuDF API. Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Feb 10, 2021
@karthikeyann karthikeyann added feature request New feature or request non-breaking Non-breaking change and removed CMake CMake build issue conda Java Affects Java cuDF API. Python Affects Python cuDF API. labels Feb 10, 2021
@github-actions github-actions bot added the CMake CMake build issue label Feb 10, 2021
@karthikeyann karthikeyann removed request for a team February 10, 2021 06:23
@karthikeyann karthikeyann added the 3 - Ready for Review Ready for review by team label Feb 10, 2021
@codecov
Copy link

codecov bot commented Feb 10, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@74a7c76). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7362   +/-   ##
==============================================
  Coverage               ?   82.20%           
==============================================
  Files                  ?      100           
  Lines                  ?    16966           
  Branches               ?        0           
==============================================
  Hits                   ?    13947           
  Misses                 ?     3019           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a7c76...b8239fa. Read the comment docs.

codereport
codereport approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@jrhemstad jrhemstad requested review from isVoid and removed request for isVoid February 10, 2021 14:11
kkraus14
kkraus14 approved these changes Feb 10, 2021
View reviewed changes
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake lgtm

@galipremsagar galipremsagar removed their request for review February 10, 2021 14:43
@karthikeyann karthikeyann added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Feb 12, 2021
@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f3bf0e5 into rapidsai:branch-0.19 Feb 12, 2021
@karthikeyann karthikeyann mentioned this pull request Feb 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codereport codereport codereport approved these changes

@jrhemstad jrhemstad jrhemstad approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] SUM_OF_SQUARES aggregation for groupby in libcudf
4 participants
@karthikeyann @kkraus14 @jrhemstad @codereport