Fix incorrect strings_column_view::chars_size documentation #7360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
added
bug
vuule
approved these changes
Feb 9, 2021
davidwendt
reviewed
Feb 9, 2021
Co-authored-by: David <[email protected]>
davidwendt
approved these changes
Feb 10, 2021
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7360 +/- ##
==============================================
Coverage ? 82.22%
==============================================
Files ? 100
Lines ? 16969
Branches ? 0
==============================================
Hits ? 13953
Misses ? 3016
Partials ? 0 Continue to review full report at Codecov.
|
harrism
approved these changes
Feb 10, 2021
harrism
added
5 - Ready to Merge
|
@gpucibot merge |
devavret
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for
strings_column_view::chars_sizeclaims that it handles sliced columns when it does not.This updates the documentation to reflect that it does not account for a sliced column view.