Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use string literals in fixed_point release_asserts #7303

Merged
merged 5 commits into from
Feb 4, 2021
Merged

Use string literals in fixed_point release_asserts #7303

merged 5 commits into from
Feb 4, 2021

Conversation

codereport
Copy link
Contributor

release_assert is only happy with string literals, not const car* and not std::string. Solution is to remove print_rep and just use a string literal.

@codereport codereport added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 4, 2021
@codereport codereport self-assigned this Feb 4, 2021
@codereport codereport requested a review from a team as a code owner February 4, 2021 01:19
devavret
devavret approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@devavret devavret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Jake said. And also, thank you.

@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Feb 4, 2021
@codereport
Copy link
Contributor Author

@gpucibot merge

@codecov
Copy link

codecov bot commented Feb 4, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@5a20adb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7303   +/-   ##
==============================================
  Coverage               ?   82.21%           
==============================================
  Files                  ?      100           
  Lines                  ?    16955           
  Branches               ?        0           
==============================================
  Hits                   ?    13939           
  Misses                 ?     3016           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a20adb...eb70279. Read the comment docs.

@rapids-bot rapids-bot bot merged commit a8f0a9b into rapidsai:branch-0.19 Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devavret devavret devavret approved these changes

@trxcllnt trxcllnt trxcllnt approved these changes

@karthikeyann karthikeyann Awaiting requested review from karthikeyann

@jrhemstad jrhemstad Awaiting requested review from jrhemstad

Assignees

@codereport codereport

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codereport @trxcllnt @devavret @jrhemstad