Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix java cuFile tests [skip ci] #7296

Merged
merged 4 commits into from
Feb 4, 2021
Merged

fix java cuFile tests [skip ci] #7296

merged 4 commits into from
Feb 4, 2021

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Feb 3, 2021

Turns out we need version > 5.4 of the junit jupiter engine to support @TempDir.

  • Changed the file mode to match Spark's disk manager.
  • Changed to use fstat to get the file length when appending.
  • Add tests for when a file already exists.

@rongou rongou requested a review from a team as a code owner February 3, 2021 20:20
@rongou rongou added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Java) Reviewer bug Something isn't working Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Feb 3, 2021
@rongou rongou requested review from revans2 and jlowe February 3, 2021 20:23
jlowe
jlowe requested changes Feb 3, 2021
View reviewed changes
java/src/main/native/src/CuFileJni.cpp Show resolved Hide resolved
java/src/main/native/src/CuFileJni.cpp Outdated Show resolved Hide resolved
java/src/test/java/ai/rapids/cudf/CuFileTest.java Show resolved Hide resolved
jlowe
jlowe requested changes Feb 3, 2021
View reviewed changes
java/src/main/native/src/CuFileJni.cpp Outdated Show resolved Hide resolved
java/src/main/native/src/CuFileJni.cpp Show resolved Hide resolved
jlowe
jlowe reviewed Feb 3, 2021
View reviewed changes
java/src/main/java/ai/rapids/cudf/CuFile.java Outdated Show resolved Hide resolved
java/src/main/native/src/CuFileJni.cpp Outdated Show resolved Hide resolved
@rongou rongou added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Java) Reviewer labels Feb 4, 2021
@revans2
Copy link
Contributor

revans2 commented Feb 4, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1062fbc into rapidsai:branch-0.18 Feb 4, 2021
@rongou rongou deleted the fix-cudfile-tests branch November 23, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

@jlowe jlowe jlowe approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rongou @revans2 @jlowe