Build.sh use cmake --build to drive build system invocation #7270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7270 +/- ##
==============================================
Coverage ? 82.20%
==============================================
Files ? 100
Lines ? 16952
Branches ? 0
==============================================
Hits ? 13936
Misses ? 3016
Partials ? 0 Continue to review full report at Codecov.
|
harrism
approved these changes
Feb 2, 2021
harrism
added
CMake
|
@robertmaynard I think since this was opened well into burndown it should technically target branch-0.19 instead. Unless this is urgently needed in 0.18. |
By using `cmake --build` instead of explicitly invoking the presumed underlying build system we allow for different CMake generators to be supported.
robertmaynard
force-pushed
the
build_script_support_user_generator
branch
from
418172f
to
2ff440f
Compare
kkraus14
approved these changes
Feb 2, 2021
raydouglass
approved these changes
Feb 2, 2021
kkraus14
added
improvement
|
rerun tests |
kkraus14
added
the
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
cmake --buildinstead of explicitly invoking the presumed underlying build system we allow for different CMake generators to be supported.