Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uvector in replace_nulls; Fix sort_helper::grouped_value doc #7256

Merged
merged 6 commits into from
Feb 4, 2021
Merged

Use uvector in replace_nulls; Fix sort_helper::grouped_value doc #7256

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bba506b
Use uvector, supplied stream and default mr
isVoid Jan 29, 2021
9cff1c0
Update grouped_value docstring
isVoid Jan 29, 2021
d9837bd
Fix grammar error
isVoid Jan 29, 2021
261ad24
Update license years
isVoid Jan 29, 2021
397287a
Address review comments
isVoid Feb 2, 2021
b241e64
Undo license change
isVoid Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/include/cudf/detail/groupby/sort_helper.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ struct sort_groupby_helper {
/**
* @brief Groups a column of values according to `keys`
*
* The order of values within each group is undefined.
* The values within each group maintain their original order.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update file copyright dates.

*
* @throw cudf::logic_error if `values.size() != keys.num_rows()`
*
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/replace/nulls.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ std::unique_ptr<cudf::column> replace_nulls_policy_impl(cudf::column_view const&
auto valid_it = cudf::detail::make_validity_iterator(*device_in);
auto in_begin = thrust::make_zip_iterator(thrust::make_tuple(index, valid_it));

rmm::device_vector<cudf::size_type> gather_map(input.size());
rmm::device_uvector<cudf::size_type> gather_map(input.size(), stream);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also update line 405 below (cudf::detail::gather call) to pass it the same stream.

auto gm_begin = thrust::make_zip_iterator(
thrust::make_tuple(gather_map.begin(), thrust::make_discard_iterator()));

Expand Down