Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export mock aws credentials for s3 tests #7176

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

ayushdg
Copy link
Member

@ayushdg ayushdg commented Jan 20, 2021

Fixes issue for failing s3 tests on machines missing aws credentials.
The PR exports fake credentials to prevent botocore from looking for aws credentials on the machine.

@ayushdg ayushdg requested a review from a team as a code owner January 20, 2021 19:26
@ayushdg ayushdg requested review from shwina and isVoid January 20, 2021 19:26
@ayushdg ayushdg requested a review from a team as a code owner January 20, 2021 19:30
@ayushdg ayushdg added the 3 - Ready for Review Ready for review by team label Jan 20, 2021
@kkraus14 kkraus14 added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change tests Unit testing for project 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jan 20, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #7176 (40b42d3) into branch-0.18 (8860baf) will increase coverage by 0.08%.
The diff coverage is 85.18%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7176      +/-   ##
===============================================
+ Coverage        82.09%   82.17%   +0.08%     
===============================================
  Files               97       97              
  Lines            16474    16543      +69     
===============================================
+ Hits             13524    13594      +70     
+ Misses            2950     2949       -1     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/lists.py 91.66% <ø> (-0.09%) ⬇️
python/cudf/cudf/core/dataframe.py 90.71% <50.00%> (+<0.01%) ⬆️
python/cudf/cudf/io/orc.py 86.80% <60.00%> (-1.61%) ⬇️
python/cudf/cudf/core/dtypes.py 89.50% <66.66%> (-0.88%) ⬇️
python/cudf/cudf/io/csv.py 91.66% <77.77%> (-1.67%) ⬇️
python/cudf/cudf/core/series.py 91.10% <80.00%> (-0.06%) ⬇️
python/cudf/cudf/core/reshape.py 91.00% <81.81%> (-0.04%) ⬇️
python/cudf/cudf/core/frame.py 89.90% <88.88%> (-0.08%) ⬇️
python/dask_cudf/dask_cudf/io/tests/test_s3.py 95.94% <94.11%> (+0.11%) ⬆️
python/cudf/cudf/core/column/numerical.py 94.08% <100.00%> (-0.33%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27893db...40b42d3. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 81952d0 into rapidsai:branch-0.18 Jan 20, 2021
@ayushdg ayushdg deleted the bug-s3-test-credentials branch March 12, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API. tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants