Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cudf::rolling_window SUM support for decimal32 and decimal64 #7147

Merged
merged 7 commits into from
Jan 18, 2021

Conversation

codereport
Copy link
Contributor

This PR resolves #7117 by adding support for cudf::rolling for the SUM option for decimal32 and decimal64.

@codereport codereport added feature request New feature or request 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond non-breaking Non-breaking change labels Jan 14, 2021
@codereport codereport requested a review from a team as a code owner January 14, 2021 21:48
@codereport codereport self-assigned this Jan 14, 2021
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an invalid fixed-point/aggregation-type you want to test with EXPECT_THROW?

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #7147 (11be93f) into branch-0.18 (8860baf) will decrease coverage by 0.00%.
The diff coverage is 84.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7147      +/-   ##
===============================================
- Coverage        82.09%   82.09%   -0.01%     
===============================================
  Files               97       97              
  Lines            16474    16516      +42     
===============================================
+ Hits             13524    13558      +34     
- Misses            2950     2958       +8     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/lists.py 91.66% <ø> (-0.09%) ⬇️
python/cudf/cudf/core/series.py 91.08% <66.66%> (-0.07%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.17% <80.00%> (-0.24%) ⬇️
python/cudf/cudf/core/reshape.py 91.00% <81.81%> (-0.04%) ⬇️
python/cudf/cudf/core/dtypes.py 89.50% <100.00%> (-0.88%) ⬇️
python/cudf/cudf/io/csv.py 90.74% <100.00%> (-2.60%) ⬇️
python/cudf/cudf/io/orc.py 86.39% <0.00%> (-2.02%) ⬇️
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e647d1a...11be93f. Read the comment docs.

@codereport codereport added 6 - Okay to Auto-Merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Jan 18, 2021
@rapids-bot rapids-bot bot merged commit 835ccf9 into rapidsai:branch-0.18 Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Fixed-point precision support for SUM in a window operation
4 participants