-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cudf::rolling_window
SUM
support for decimal32
and decimal64
#7147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an invalid fixed-point/aggregation-type you want to test with EXPECT_THROW?
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7147 +/- ##
===============================================
- Coverage 82.09% 82.09% -0.01%
===============================================
Files 97 97
Lines 16474 16516 +42
===============================================
+ Hits 13524 13558 +34
- Misses 2950 2958 +8
Continue to review full report at Codecov.
|
This PR resolves #7117 by adding support for
cudf::rolling
for theSUM
option fordecimal32
anddecimal64
.