Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Implement __hash__ method for ListDtype #7081

Merged
merged 4 commits into from
Jan 6, 2021

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Jan 5, 2021

Fixes: #7070

This PR fixes a failure in to_pandas when nullable is set to True. The changes in this PR implement __hash__ in listDtype.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Jan 5, 2021
@galipremsagar galipremsagar self-assigned this Jan 5, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner January 5, 2021 22:44
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #7081 (6ccd860) into branch-0.18 (1930432) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7081      +/-   ##
===============================================
+ Coverage        82.09%   82.12%   +0.02%     
===============================================
  Files               97       97              
  Lines            16486    16490       +4     
===============================================
+ Hits             13535    13542       +7     
+ Misses            2951     2948       -3     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/lists.py 91.66% <ø> (-0.09%) ⬇️
python/cudf/cudf/core/dtypes.py 90.50% <100.00%> (+0.12%) ⬆️
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 91.48% <0.00%> (+4.25%) ⬆️
python/cudf/cudf/utils/gpu_utils.py 58.53% <0.00%> (+4.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1930432...6ccd860. Read the comment docs.

Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. At this point, I think it would make more sense for the title of this PR to indicate that it implements __hash__ for list types. The to_pandas failure is a consequence of us not having one to begin with.

@galipremsagar galipremsagar changed the title [REVIEW] Fix to_pandas failure incase of list column when nullable=True [REVIEW] Implement __hash__ method for ListDtype Jan 6, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge 6 - Okay to Auto-Merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Jan 6, 2021
@rapids-bot rapids-bot bot merged commit 8787a64 into rapidsai:branch-0.18 Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Dataframe with list column errors when to_pandas(nullable=True)
2 participants