-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Implement __hash__
method for ListDtype
#7081
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7081 +/- ##
===============================================
+ Coverage 82.09% 82.12% +0.02%
===============================================
Files 97 97
Lines 16486 16490 +4
===============================================
+ Hits 13535 13542 +7
+ Misses 2951 2948 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. At this point, I think it would make more sense for the title of this PR to indicate that it implements __hash__
for list types. The to_pandas
failure is a consequence of us not having one to begin with.
nullable=True
__hash__
method for ListDtype
Fixes: #7070
This PR fixes a failure in
to_pandas
whennullable
is set toTrue
. The changes in this PR implement__hash__
inlistDtype
.