cudf::rolling ROW_NUMBER support for decimal32 and decimal64
#7061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codereport
added
feature request
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7061 +/- ##
===============================================
+ Coverage 82.09% 82.11% +0.02%
===============================================
Files 97 97
Lines 16474 16477 +3
===============================================
+ Hits 13524 13530 +6
+ Misses 2950 2947 -3
Continue to review full report at Codecov.
|
codereport
added
3 - Ready for Review
…p-rolling-row-number
davidwendt
reviewed
Jan 4, 2021
mythrocks
reviewed
Jan 4, 2021
| @@ -73,7 +73,7 @@ class aggregation { | |||
| ARGMIN, ///< Index of min element | |||
| NUNIQUE, ///< count number of unique elements | |||
| NTH_ELEMENT, ///< get the nth element | |||
| ROW_NUMBER, ///< get row-number of element | |||
| ROW_NUMBER, ///< get row-number of current index (relative to rolling window) | |||
There was a problem hiding this comment.
Thank you for fixing this, @codereport. I should have made it clear here that this aggregation is specific to window functions.
devavret
approved these changes
Jan 5, 2021
codereport
added
6 - Okay to Auto-Merge
and removed
3 - Ready for Review
6 tasks
27 tasks
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
cudf::rollingfor theROW_NUMBERoption fordecimal32anddecimal64. It also clarifies the documentation.