Implement cudf::rolling for decimal32 and decimal64
#7037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codereport
added
feature request
45 tasks
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7037 +/- ##
===============================================
+ Coverage 82.09% 82.11% +0.02%
===============================================
Files 97 97
Lines 16477 16480 +3
===============================================
+ Hits 13527 13533 +6
+ Misses 2950 2947 -3
Continue to review full report at Codecov.
|
codereport
requested review from
cwharris,
jrhemstad,
rgsl888prabhu and
karthikeyann
and removed request for
cwharris and
jrhemstad
| return data_type{type_to_id<target_type_t<Source, k>>()}; | ||
| auto const id = type_to_id<target_type_t<Source, k>>(); | ||
| return id == type_id::DECIMAL32 || id == type_id::DECIMAL64 ? data_type{id, type.scale()} | ||
| : data_type{id}; |
There was a problem hiding this comment.
why skip scale for non-decimal type? (It will have default value, anyway it won't be used).
There was a problem hiding this comment.
Ctor with scale only designed to be called for Decimal types.
explicit data_type(type_id id, int32_t scale) : _id{id}, _fixed_point_scale{scale}
{
assert(id == type_id::DECIMAL32 || id == type_id::DECIMAL64);
}
vuule
approved these changes
Dec 30, 2020
rgsl888prabhu
approved these changes
Dec 31, 2020
codereport
added
6 - Okay to Auto-Merge
and removed
2 - In Progress
6 tasks
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a part of #3556.
Aggregation ops supported:
MINMAXCOUNT(bothnull_policy-EX/INCLUDE)LEADLAGTo Do List: