Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ffill and bfill to string columns #7036

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Dec 17, 2020

Follow up of PR #7004

Adds method field to fillna method in string type column to support ffill and bfill.
Also involves a small change to a datetime64 ffill, bfill test case to improve test robustness.

@isVoid isVoid added feature request New feature or request 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. non-breaking Non-breaking change labels Dec 17, 2020
@isVoid isVoid self-assigned this Dec 17, 2020
@isVoid isVoid requested a review from a team as a code owner December 17, 2020 22:57
@isVoid isVoid changed the title Adds ffill and bfill to string columns Add ffill and bfill to string columns Dec 17, 2020
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge 6 - Okay to Auto-Merge and removed 3 - Ready for Review Ready for review by team labels Dec 17, 2020
@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #7036 (9b24a4e) into branch-0.18 (4385f54) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7036      +/-   ##
===============================================
+ Coverage        82.05%   82.07%   +0.01%     
===============================================
  Files               96       96              
  Lines            16406    16415       +9     
===============================================
+ Hits             13462    13472      +10     
+ Misses            2944     2943       -1     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 86.62% <100.00%> (+0.13%) ⬆️
python/cudf/cudf/core/frame.py 89.97% <0.00%> (-0.29%) ⬇️
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 91.48% <0.00%> (+4.25%) ⬆️
python/cudf/cudf/utils/gpu_utils.py 58.53% <0.00%> (+4.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4385f54...9b24a4e. Read the comment docs.

@rapids-bot rapids-bot bot merged commit ae90dd9 into rapidsai:branch-0.18 Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants