-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix read_orc
for decimal type
#7034
Fix read_orc
for decimal type
#7034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find 👍
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7034 +/- ##
===============================================
+ Coverage 82.03% 82.23% +0.19%
===============================================
Files 96 96
Lines 16381 16670 +289
===============================================
+ Hits 13438 13708 +270
- Misses 2943 2962 +19
Continue to review full report at Codecov.
|
The
run_pos
which was being used was from data rather from secondary stream which was for scale, but resulted value was being used for secondary streamscale
. The code change fixes that issue and also adds test case to cover the issue.closes #7016