Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read_orc for decimal type #7034

Merged
merged 2 commits into from
Dec 18, 2020

Conversation

rgsl888prabhu
Copy link
Contributor

The run_pos which was being used was from data rather from secondary stream which was for scale, but resulted value was being used for secondary stream scale. The code change fixes that issue and also adds test case to cover the issue.

closes #7016

@rgsl888prabhu rgsl888prabhu added bug Something isn't working Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer cuIO cuIO issue non-breaking Non-breaking change labels Dec 17, 2020
@rgsl888prabhu rgsl888prabhu requested review from a team as code owners December 17, 2020 21:52
@rgsl888prabhu rgsl888prabhu self-assigned this Dec 17, 2020
@rgsl888prabhu rgsl888prabhu added the 3 - Ready for Review Ready for review by team label Dec 17, 2020
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find 👍

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #7034 (9c1f7df) into branch-0.18 (8c1f01e) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7034      +/-   ##
===============================================
+ Coverage        82.03%   82.23%   +0.19%     
===============================================
  Files               96       96              
  Lines            16381    16670     +289     
===============================================
+ Hits             13438    13708     +270     
- Misses            2943     2962      +19     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/timedelta.py 89.16% <0.00%> (-0.38%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.41% <0.00%> (-0.16%) ⬇️
python/cudf/cudf/core/column/string.py 86.48% <0.00%> (-0.10%) ⬇️
python/cudf/cudf/core/series.py 91.10% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 89.42% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 93.35% <0.00%> (+0.01%) ⬆️
python/cudf/cudf/core/column/column.py 88.14% <0.00%> (+0.10%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1f01e...9c1f7df. Read the comment docs.

@vuule vuule added 5 - Ready to Merge Testing and reviews complete, ready to merge 6 - Okay to Auto-Merge libcudf Affects libcudf (C++/CUDA) code. and removed 3 - Ready for Review Ready for review by team 4 - Needs cuIO Reviewer labels Dec 18, 2020
@rapids-bot rapids-bot bot merged commit c24171b into rapidsai:branch-0.18 Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cudf.read_orc gives incorrect values with decimal dtype
4 participants