Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix backward compatibility of loading a 0.16 pkl file #7033

Merged
merged 2 commits into from
Dec 18, 2020

Conversation

galipremsagar
Copy link
Contributor

Fixes: #7025

This PR:

  1. Handles loading of pickle files which have been created with rangeIndex prior to introduction of step parameter support.
  2. Introduces special-case handling of stringcolumn size where we were previously storing it as a pickled object.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Dec 17, 2020
@galipremsagar galipremsagar self-assigned this Dec 17, 2020
@galipremsagar galipremsagar requested a review from a team as a code owner December 17, 2020 20:44
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #7033 (cc1dfe8) into branch-0.18 (da60cce) will increase coverage by 0.84%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7033      +/-   ##
===============================================
+ Coverage        82.04%   82.88%   +0.84%     
===============================================
  Files               96       96              
  Lines            16388    17597    +1209     
===============================================
+ Hits             13446    14586    +1140     
- Misses            2942     3011      +69     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 87.51% <100.00%> (+0.93%) ⬆️
python/cudf/cudf/core/index.py 93.25% <100.00%> (ø)
python/cudf/cudf/core/frame.py 89.40% <0.00%> (-0.95%) ⬇️
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 89.52% <0.00%> (+0.10%) ⬆️
python/dask_cudf/dask_cudf/io/csv.py 95.71% <0.00%> (+0.19%) ⬆️
python/cudf/cudf/core/column/categorical.py 93.62% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 83.73% <0.00%> (+0.71%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da60cce...cc1dfe8. Read the comment docs.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge 6 - Okay to Auto-Merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Dec 18, 2020
@rapids-bot rapids-bot bot merged commit 9317361 into rapidsai:branch-0.18 Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] unable to load a pickled dataframe from 0.16 into cudf 0.17+
2 participants