Restore usual instance/subclass checking to cudf.DateOffset #7029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pd.DateOffset
uses a metaclass that overrides the usual instance/subclass checking behaviour. Any subclass ofpd._libs.tslibs.offsets.BaseOffset
will be reported as a subclass ofpd.DateOffset
(itself apd.DateOffset
). This can lead to some surprising behaviour:Note that
cudf.DateOffset
inherits frompd.DateOffset
. But, apd.DateOffset
is reported as an instance ofcudf.DateOffset
-- Child Is Father of the Man!