Add days check to cudf::is_timestamp using cuda::std::chrono classes #7028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
jrhemstad
reviewed
Dec 17, 2020
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7028 +/- ##
===============================================
+ Coverage 82.09% 82.11% +0.01%
===============================================
Files 97 97
Lines 16477 16477
===============================================
+ Hits 13527 13530 +3
+ Misses 2950 2947 -3
Continue to review full report at Codecov.
|
vuule
approved these changes
Dec 17, 2020
devavret
suggested changes
Dec 28, 2020
davidwendt
added
breaking
devavret
approved these changes
Jan 5, 2021
karthikeyann
approved these changes
Jan 5, 2021
jrhemstad
reviewed
Jan 5, 2021
| @@ -84,7 +84,7 @@ std::unique_ptr<column> to_timestamps( | |||
| * | :-------: | ----------- | | |||
| * | \%d | Day of the month: 01-31 | | |||
| * | \%m | Month of the year: 01-12 | | |||
| * | \%y | Year without century: 00-99 | | |||
| * | \%y | Year without century: 00-99. [0,68] maps to [2000,2068] and [69,99] maps to [1969,1999] | | |||
There was a problem hiding this comment.
We could add a %C format string to specify the century like std::chrono::parse: https://en.cppreference.com/w/cpp/chrono/parse
jrhemstad
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6774
This PR adds a check for a valid day value for a year/month (if these are specified in the format) in the
cudf::is_timestamp()API. Also, a chunk of messy year/month/day logic in a related functor was replaced with libcu++ implementation of theyear_month_day()function instead.A gtest is also updated to include to test for an invalid day.