-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cudf::hash_partition
for decimal32
and decimal64
#7006
Fix cudf::hash_partition
for decimal32
and decimal64
#7006
Conversation
I ran with this patch and it fixed the issues I was seeing in Spark. |
👍 I am just putting together another unit test for |
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7006 +/- ##
============================================
Coverage 82.01% 82.01%
============================================
Files 96 96
Lines 16338 16340 +2
============================================
+ Hits 13400 13402 +2
Misses 2938 2938
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how much more of this is around. This is a subtle difference and easy to miss.
The fix is subtle but the API ( It is on my list of things to do to go through every API at some point and make sure there are tests. |
This resolves #6996