Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loc behaviour when key of incorrect type is used #6993

Merged
merged 8 commits into from
Dec 16, 2020
Merged

Fix loc behaviour when key of incorrect type is used #6993

merged 8 commits into from
Dec 16, 2020

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Dec 11, 2020

@shwina shwina requested a review from a team as a code owner December 11, 2020 20:38
@shwina shwina added bug Something isn't working non-breaking Non-breaking change labels Dec 11, 2020
@shwina shwina marked this pull request as draft December 11, 2020 23:12
@shwina shwina marked this pull request as ready for review December 11, 2020 23:13
@codecov
Copy link

codecov bot commented Dec 12, 2020 •
edited
Loading

Codecov Report

Merging #6993 (70ff231) into branch-0.18 (ab8c931) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #6993      +/-   ##
===============================================
+ Coverage        82.01%   82.03%   +0.02%     
===============================================
  Files               96       96              
  Lines            16338    16358      +20     
===============================================
+ Hits             13400    13420      +20     
  Misses            2938     2938
Impacted Files Coverage Δ
python/cudf/cudf/core/column/numerical.py 94.40% <100.00%> (-0.14%) ⬇️
python/cudf/cudf/core/indexing.py 96.35% <100.00%> (+0.72%) ⬆️
python/cudf/cudf/io/dlpack.py 93.75% <0.00%> (-1.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8c931...70ff231. Read the comment docs.

rgsl888prabhu
rgsl888prabhu reviewed Dec 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/numerical.py Show resolved Hide resolved
python/cudf/cudf/core/column/numerical.py Show resolved Hide resolved
rgsl888prabhu
rgsl888prabhu approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

isVoid
isVoid reviewed Dec 14, 2020
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case qst, otherwise lgtm!

python/cudf/cudf/tests/test_indexing.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_indexing.py Outdated Show resolved Hide resolved
isVoid
isVoid approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@galipremsagar galipremsagar added the Python Affects Python cuDF API. label Dec 16, 2020
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge 6 - Okay to Auto-Merge labels Dec 16, 2020
@rapids-bot rapids-bot bot merged commit 7ca3fad into rapidsai:branch-0.18 Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@isVoid isVoid isVoid approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Passing incorrectly typed object to Series.__getitem__ causes uninformative Numba exception
4 participants
@shwina @galipremsagar @isVoid @rgsl888prabhu