-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default parameter values of write_csv
and write_parquet
#6967
Conversation
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #6967 +/- ##
===============================================
+ Coverage 81.59% 82.93% +1.33%
===============================================
Files 96 96
Lines 15907 17388 +1481
===============================================
+ Hits 12980 14420 +1440
- Misses 2927 2968 +41
Continue to review full report at Codecov.
|
Rerun tests |
Fixes #6671, #6851
rows_per_chunk
incsv_writer_options
to the size of the input table.rows_per_chunk
type tosize_type
(used for number of rows).to_parquet
/write_parquet
to "snappy".