-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JNI wrapper for the cuFile API (GDS) [skip ci] #6940
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
rongou
added
3 - Ready for Review
Ready for review by team
4 - Needs cuDF (Java) Reviewer
Java
Affects Java cuDF API.
doc
Documentation
non-breaking
Non-breaking change
Spark
Functionality that helps Spark RAPIDS
labels
Dec 8, 2020
revans2
reviewed
Dec 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
revans2
reviewed
Dec 9, 2020
rongou
changed the title
[REVIEW] Add JNI wrapper for the cuFile API (GDS) [skip ci]
Add JNI wrapper for the cuFile API (GDS) [skip ci]
Dec 10, 2020
revans2
approved these changes
Dec 10, 2020
11 tasks
vyasr
added
4 - Needs Review
Waiting for reviewer to review or respond
and removed
4 - Needs cuDF (Java) Reviewer
labels
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
4 - Needs Review
Waiting for reviewer to review or respond
doc
Documentation
Java
Affects Java cuDF API.
non-breaking
Non-breaking change
Spark
Functionality that helps Spark RAPIDS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
libcufilejni.so
that's by default not built nor loaded. The unit tests are controlled similarly.Tested locally with the corresponding spark-rapids plugin changes.
@jlowe @revans2 @abellina