Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add Index.set_names api #6929

Merged
merged 8 commits into from
Dec 8, 2020
Merged

[REVIEW] Add Index.set_names api #6929

merged 8 commits into from
Dec 8, 2020

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Dec 6, 2020 •
edited
Loading

Resolves: #6870

This PR adds support for set_names API in both Index & MultiIndex.

@galipremsagar galipremsagar added feature request New feature or request 2 - In Progress Currently a work in progress Python Affects Python cuDF API. non-breaking Non-breaking change labels Dec 6, 2020
@galipremsagar galipremsagar self-assigned this Dec 6, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@galipremsagar galipremsagar linked an issue Dec 6, 2020 that may be closed by this pull request
[FEA] Implement set_names for cuDF.Index #6870
Closed
@galipremsagar galipremsagar marked this pull request as ready for review December 7, 2020 21:45
@galipremsagar galipremsagar requested a review from a team as a code owner December 7, 2020 21:45
@galipremsagar galipremsagar changed the title [WIP] Add Index.set_names api [REVIEW] Add Index.set_names api Dec 7, 2020
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer and removed 2 - In Progress Currently a work in progress labels Dec 7, 2020
kkraus14
kkraus14 requested changes Dec 7, 2020
View reviewed changes
python/cudf/cudf/core/index.py Show resolved Hide resolved
python/cudf/cudf/core/multiindex.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_index.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_multiindex.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 8, 2020 •
edited
Loading

Codecov Report

Merging #6929 (0feacf1) into branch-0.18 (598a14d) will increase coverage by 0.47%.
The diff coverage is 97.29%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #6929      +/-   ##
===============================================
+ Coverage        81.53%   82.01%   +0.47%     
===============================================
  Files               96       96              
  Lines            15876    16267     +391     
===============================================
+ Hits             12945    13341     +396     
+ Misses            2931     2926       -5
Impacted Files Coverage Δ
python/cudf/cudf/core/index.py 93.25% <93.75%> (+0.49%) ⬆️
python/cudf/cudf/core/multiindex.py 81.20% <100.00%> (+1.49%) ⬆️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598a14d...0feacf1. Read the comment docs.

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge 6 - Okay to Auto-Merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Dec 8, 2020
@rapids-bot rapids-bot bot merged commit 917759b into rapidsai:branch-0.18 Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@shwina shwina Awaiting requested review from shwina

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Implement set_names for cuDF.Index
3 participants
@galipremsagar @GPUtester @kkraus14