Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix rolling-window count for null input #6344

Merged
merged 20 commits into from
Oct 13, 2020
Merged

[REVIEW] Fix rolling-window count for null input #6344

merged 20 commits into from
Oct 13, 2020

Commits on Sep 29, 2020

  1. Fix rolling-window count for null input

    @mythrocks
    mythrocks committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    8211a68 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Merge remote-tracking branch 'origin/branch-0.16' into window-count-fix

    @mythrocks
    mythrocks committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    4da93f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Rolling Window count fix: Fixing python tests.

    @mythrocks
    mythrocks committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    4d3c7b1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/branch-0.16' into window-count-fix

    @mythrocks
    mythrocks committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    59a36f3 View commit details
    Browse the repository at this point in the history

  3. Rolling Window count fix: Using marks for xfail.

    @mythrocks
    mythrocks committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    3b55909 View commit details
    Browse the repository at this point in the history

  4. Rolling Window count fix: Fixed formatting

    @mythrocks
    mythrocks committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    90aa2a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Merge remote-tracking branch 'origin/branch-0.16' into window-count-fix

    @mythrocks
    mythrocks committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    2be5049 View commit details
    Browse the repository at this point in the history

  2. Rolling Window count fix: Review fixes: 

    1. Short-ckt return for when output is invalid
2. Removed unnecessary volatile qualifier
3. Code-formatting for test_rolling.py
    @mythrocks
    mythrocks committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    160d9b2 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. Rolling Window count fix: Review fixes: 

    1. Switched explicit for-loop to thrust::count_if().
2. Fixed spelling in rolling-window python tests.
    @mythrocks
    mythrocks committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    1298b0c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/branch-0.16' into window-count-fix

    @mythrocks
    mythrocks committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    8697cf1 View commit details
    Browse the repository at this point in the history

  3. Rolling Window count fix: Review fixes: 

    3. Switched SFINAE from return-type to template parameter.
    @mythrocks
    mythrocks committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    9a4b168 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/branch-0.16' into window-count-fix

    @mythrocks
    mythrocks committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    45003cd View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. Merge remote-tracking branch 'origin/branch-0.16' into window-count-fix

    @mythrocks
    mythrocks committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    6264fcc View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Merge remote-tracking branch 'origin/branch-0.16' into window-count-fix

    @mythrocks
    mythrocks committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    c982404 View commit details
    Browse the repository at this point in the history

  2. Rolling Window count fix: Fixed formatting

    @mythrocks
    mythrocks committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    d901023 View commit details
    Browse the repository at this point in the history

  3. Rolling Window count fix: Fixed process_rolling_window for COUNT_ALL

    @mythrocks
    mythrocks committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    f7a8c90 View commit details
    Browse the repository at this point in the history

  4. Rolling Window count fix: Use is_valid_no_check().

    @mythrocks
    mythrocks committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    f34835b View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2020

  1. Rolling Window count fix: Python review 

    1. Added test for expected values for rolling_window count
2. Fixed convention for parametrized agg values
    @mythrocks
    mythrocks committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    62709b8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/branch-0.16' into window-count-fix

    @mythrocks
    mythrocks committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    7f9b391 View commit details
    Browse the repository at this point in the history

  3. Rolling Window count fix: Python review 

    3. Reformatting
    @mythrocks
    mythrocks committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    6445c5d View commit details
    Browse the repository at this point in the history