[REVIEW] Fix getattr logic in GroupBy #5578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
shwina
commented
Jun 25, 2020
| def test_groupby_attribute_error(): | ||
| err_msg = "Test error message" | ||
|
|
||
| class TestGroupBy(cudf.core.groupby.GroupBy): |
There was a problem hiding this comment.
We're depending on some internals of groupby in this test. I don't like it but couldn't figure out a better solution
There was a problem hiding this comment.
By internals are you just referring to cudf.core.groupby.GroupBy?
kkraus14
approved these changes
Jun 25, 2020
kkraus14
added
5 - Ready to Merge
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.15 #5578 +/- ##
===============================================
- Coverage 88.65% 85.86% -2.79%
===============================================
Files 57 72 +15
Lines 10945 12172 +1227
===============================================
+ Hits 9703 10452 +749
- Misses 1242 1720 +478
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that our logic for
getattrin GroupBy could lead to misleading error messages when anAttributeErroris raised within anypropertys in GroupBy. See encode/django-rest-framework#2108 for a description of the problem.