Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Change String typecasting to be inline with Pandas #5054

Merged
merged 48 commits into from
May 12, 2020
Merged

[REVIEW] Change String typecasting to be inline with Pandas #5054

merged 48 commits into from
May 12, 2020

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Apr 30, 2020 •
edited
Loading

Fixes: #2707

  • Add cython bindings.
  • Make changes to astype logic.
  • Add docs.

Fixes: #5136

@galipremsagar galipremsagar added 2 - In Progress Currently a work in progress Python Affects Python cuDF API. strings strings issues (C++ and Python) labels Apr 30, 2020
@galipremsagar galipremsagar self-assigned this Apr 30, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@galipremsagar galipremsagar mentioned this pull request May 3, 2020
Closed
@galipremsagar galipremsagar changed the title [WIP] Change String typecasting to be inline with Pandas [REVIEW] Change String typecasting to be inline with Pandas May 5, 2020
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer and removed 2 - In Progress Currently a work in progress labels May 5, 2020
@galipremsagar galipremsagar marked this pull request as ready for review May 5, 2020 21:45
@galipremsagar galipremsagar requested a review from a team as a code owner May 5, 2020 21:45
rgsl888prabhu
rgsl888prabhu reviewed May 5, 2020
View reviewed changes
python/cudf/cudf/tests/test_dataframe.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_sorting.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_string.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 5, 2020 •
edited
Loading

Codecov Report

Merging #5054 into branch-0.14 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.14    #5054   +/-   ##
============================================
  Coverage        88.49%   88.49%           
============================================
  Files               55       55           
  Lines            10429    10429           
============================================
  Hits              9229     9229           
  Misses            1200     1200

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a552395...a552395. Read the comment docs.

@galipremsagar galipremsagar changed the title [REVIEW] Change String typecasting to be inline with Pandas [WIP] Change String typecasting to be inline with Pandas May 11, 2020
@galipremsagar galipremsagar added 2 - In Progress Currently a work in progress and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels May 11, 2020
@galipremsagar galipremsagar changed the title [WIP] Change String typecasting to be inline with Pandas [REVIEW] Change String typecasting to be inline with Pandas May 11, 2020
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer and removed 2 - In Progress Currently a work in progress labels May 11, 2020
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels May 12, 2020
@kkraus14 kkraus14 merged commit 4d0ecf0 into rapidsai:branch-0.14 May 12, 2020
@rgsl888prabhu rgsl888prabhu mentioned this pull request May 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt left review comments

@rgsl888prabhu rgsl888prabhu rgsl888prabhu left review comments

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API. strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
5 participants
@galipremsagar @GPUtester @kkraus14 @rgsl888prabhu @davidwendt